linux-kernel - Re: [PATCH] hostfs: Use correct mask for file mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 May 2015 15:25:30 +0200
From:	Richard Weinberger <richard@....at>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	markus.stenberg@....fi
Subject: Re: [PATCH] hostfs: Use correct mask for file mode

Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven:
> On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger <richard@....at> wrote:
>> --- a/fs/hostfs/hostfs_kern.c
>> +++ b/fs/hostfs/hostfs_kern.c
>> @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
>>         if (name == NULL)
>>                 goto out_put;
>>
>> -       fd = file_create(name, mode & S_IFMT);
>> +       fd = file_create(name, mode & 0777);
> 
> "(S_IRWXU | S_IRWXG | S_IRWXO)"?

I thought about that too but did not see a real benefit
as 0777 is well known and self describing.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/