linux-kernel - Re: [PATCH] HSI: cmt_speech: fix timestamp interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150504140254.GB13164@earth>
Date:	Mon, 4 May 2015 16:02:54 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Pavel Machek <pavel@....cz>, Aaro Koskinen <aaro.koskinen@....fi>,
	Kai Vehmanen <kvehmanen@...ignal.fi>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HSI: cmt_speech: fix timestamp interface

Hi Arnd,

On Thu, Apr 16, 2015 at 07:13:50PM +0200, Sebastian Reichel wrote:
> The user interface for timestamps in the new cmt_speech
> driver is broken in multiple ways:
> 
> - The layout is incompatible between 32-bit and 64-bit user
>   space, because of the size differences in 'struct timespec'.
>   This means that the driver can not work when used with 32-bit
>   user space on a 64-bit kernel.
> 
> - As there are plans to change 32-bit user space to use
>   a 64-bit time_t type in the future, it will also be
>   incompatible with new 32-bit user space.
> 
> To keep support for the user space tools written for this driver (which
> have lived many years out-of-tree), the interface has been hardened to
> unsigned 32-bit values.

Are you fine with this patch? I would like to queue it for 4.1-rc.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)