linux-kernel - Re: [PATCH] blk-mq: fix FUA request hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5547C430.7040105@fb.com>
Date:	Mon, 4 May 2015 13:10:40 -0600
From:	Jens Axboe <axboe@...com>
To:	Shaohua Li <shli@...com>, <linux-kernel@...r.kernel.org>
CC:	<Kernel-team@...com>
Subject: Re: [PATCH] blk-mq: fix FUA request hang

On 05/01/2015 10:59 AM, Shaohua Li wrote:
> When a FUA request enters its DATA stage of flush pipeline, the
> request is added to mq requeue list, the request will then be added to
> ctx->rq_list. blk_mq_attempt_merge() might merge the request with a bio.
> Later when the request is finished the flush pipeline, the
> request->__data_len is 0. Then I only saw the bio gets endio called, the
> original request never finish.
>
> Adding REQ_FLUSH_SEQ into REQ_NOMERGE_FLAGS looks an easy fix.

Thanks, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/