linux-kernel - [PATCH 0/3] seq_file allocation in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue,  5 May 2015 00:19:12 +0200
From:	Yann Droneaud <ydroneaud@...eya.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yann Droneaud <ydroneaud@...eya.com>
Subject: [PATCH 0/3] seq_file allocation in seq_open()

Hi,

I found myself trying to use seq_open() and experiencing
crash as seq_open() was using my private data in
file->private_data as its own struct seq_file.

It should be noted such behavior is not documented.

It's also an issue if seq_release() is used in release
handler, as it will kfree() a pointer which was not
allocated by seq_open().

So, please find a patchset that drop the support for
pre-allocated struct seq_file in seq_open(): it's
only of use in proc_namespace.c and can be easily
replaced by using seq_open_private()/seq_release_private().

Additionally, it documents the use of file->private_data
to hold pointer to struct seq_file.

Yann Droneaud (3):
  fs: use seq_open_private() for proc_mounts
  fs: allocate structure unconditionally in seq_open()
  fs: documents seq_open()'s usage of file->private_data

 fs/mount.h          |  3 ---
 fs/namespace.c      |  6 +++---
 fs/proc_namespace.c | 34 ++++++++++++++++------------------
 fs/seq_file.c       | 18 +++++++++++-------
 4 files changed, 30 insertions(+), 31 deletions(-)

-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/