linux-kernel - Re: [PATCH v4 11/20] clk: tegra: pll: Add code to handle if resets are supported by PLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 10:15:47 -0700
From:	Benson Leung <bleung@...omium.org>
To:	Rhyland Klein <rklein@...dia.com>
Cc:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bill Huang <bilhuang@...dia.com>
Subject: Re: [PATCH v4 11/20] clk: tegra: pll: Add code to handle if resets
 are supported by PLL

On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein <rklein@...dia.com> wrote:
> From: Bill Huang <bilhuang@...dia.com>
>
> If a PLL has a reset_reg specified, properly handle that in the
> enable/disable logic paths.
>
> Signed-off-by: Bill Huang <bilhuang@...dia.com>

Minor nit to add kerneldoc for params. Otherwise, LGTM.

Reviewed-by: Benson Leung <bleung@...omium.org>

> diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
> index b63ef31a2d7a..0146c91df635 100644
> --- a/drivers/clk/tegra/clk.h
> +++ b/drivers/clk/tegra/clk.h
> @@ -217,6 +217,8 @@ struct tegra_clk_pll_params {
>         u32             lock_enable_bit_idx;
>         u32             iddq_reg;
>         u32             iddq_bit_idx;
> +       u32             reset_reg;
> +       u32             reset_bit_idx;

Kerneldoc for these two.

>         u32             sdm_din_reg;
>         u32             sdm_din_mask;
>         u32             sdm_ctrl_reg;




-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@...omium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/