linux-kernel - Re: [PATCH v5 2/6] x86/mm/pat: redefine pat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 02:42:24 +0200
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Borislav Petkov <bp@...e.de>
Cc:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>, mingo@...e.hu,
	tglx@...utronix.de, hpa@...or.com, plagnioj@...osoft.com,
	tomi.valkeinen@...com, daniel.vetter@...el.com, airlied@...ux.ie,
	dledford@...hat.com, awalls@...metrocast.net, syrjala@....fi,
	luto@...capital.net, mst@...hat.com, cocci@...teme.lip6.fr,
	linux-kernel@...r.kernel.org, Christoph Lameter <cl@...ux.com>,
	Kyle McMartin <kyle@...nel.org>,
	Juergen Gross <jgross@...e.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Dave Airlie <airlied@...hat.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, x86@...nel.org
Subject: Re: [PATCH v5 2/6] x86/mm/pat: redefine pat_enabled

On Mon, May 04, 2015 at 05:22:08PM +0200, Borislav Petkov wrote:
> On Thu, Apr 30, 2015 at 01:25:16PM -0700, Luis R. Rodriguez wrote:
> > diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> > index bfef424..f094d36 100644
> > --- a/arch/x86/kernel/cpu/mtrr/main.c
> > +++ b/arch/x86/kernel/cpu/mtrr/main.c
> > @@ -556,7 +556,7 @@ int arch_phys_wc_add(unsigned long base, unsigned long size)
> >  {
> >  	int ret;
> >  
> > -	if (pat_enabled || !mtrr_enabled)
> > +	if (pat_enabled() || !mtrr_enabled)
> 
> What's going on here? I got a reject about mtrr_enabled which is nowhere
> to be found. Am I missing a patch?

Yes, the patch titled, "x86: mtrr: generalize run time disabling of MTRR"
should be applied first, or ammended to fit the new style. Let me know what
you prefer.

> Anyway, I applied that:

Great, thanks, is there a tree I can use to rebase / fetch ?

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/