linux-kernel - Re: [PATCH RFC] checkpatch: flag split arithmetic operations with CHECK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 20:40:55 +0200
From:	Nicholas Mc Guire <der.herr@...r.at>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Nicholas Mc Guire <hofrat@...dl.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] checkpatch: flag split arithmetic operations with
	CHECK

On Tue, 05 May 2015, Joe Perches wrote:

> On Tue, 2015-05-05 at 16:08 +0200, Nicholas Mc Guire wrote:
> > On Tue, 05 May 2015, Andy Whitcroft wrote:
> > > On Tue, May 05, 2015 at 10:53:36AM +0200, Nicholas Mc Guire wrote:
> > > > Simple arithmetic operations should be on one line, if they can be fit,
> > > > rather than splitting at the operator. As this is not in the CodingStyle it 
> > > > is limited to --strict use of checkpatch.pl and emits a CHECK only.
> []
> > > I assume that these relate to being able to confirm the variant of the
> > > operator, unary/binary etc.  If you look for "annotate_values", after
> > > that is run there is additional information for each character of the
> > > current line, tracking the type of the operator.  This is used when
> > > determining spacing for + etc later as unary ones are typically tight
> > > bound and binary ones spaced out.  You might find that useful, if that
> > > is your issue.  And indeed you might find it useful for determining if
> > > the +/- you find at line end is indeed unary.  Running with --debug
> > > values=1 should dump out the variants information for those.
> > >
> > thanks - looks like a useful (somewhat cryptic) starting point
> > 
> > 15 > .  x = y - x
> > 15 > EEEVVNNVVNNTTT
> > 15 >  ________B____
> > 
> > will give it a try to generalize it for all basic binary operators.
> 
> Look at the code for "# Check operator spacing" around line 3600.
> It's a pretty big block of ~300 lines of code, but this new test
> should go in there.
>
will move it then once its working - checkpatch.pl is a bit hard to navigate
in for me - was not clear where it would fit in. will cleanup and repost.

thx!
hofrat 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/