linux-kernel - Re: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 15:30:06 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
cc:	Kernel development list <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>,
	USB list <linux-usb@...r.kernel.org>,
	<gregkh@...uxfoundation.org>
Subject: Re: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host
 driver

On Tue, 5 May 2015, Ramneek Mehresh wrote:

> Add workqueue to add/remove host driver (outside interrupt context)
> upon each id change
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@...escale.com>
> ---
> Changes for v3:
> 	- use overrides for ehci_fsl_overrides
> 	- remove struct ehci_hcd from ehci_fsl
> 	- move ehci_fsl to ehci-fsl.h

This patch changes at least three separate things:

	It adds the workqueue stuff.

	It replaces ehci_fsl_hc_driver with ehci_fsl_overrides.

	It adds new fields into the overrides structure.

A patch should do only one thing.  It certainly shouldn't make three
separate, major changes!

Also, I'm not going to let you add new fields into the 
ehci_driver_overrides structure.  If you really need to override other
routines, copy the approach used by ehci-tegra.c.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/