linux-kernel - Re: [PATCH v4 09/20] clk: tegra: pll: Add logic for SS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 16:15:59 -0400
From:	Rhyland Klein <rklein@...dia.com>
To:	Benson Leung <bleung@...omium.org>
CC:	Peter De Schrijver <pdeschrijver@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	<linux-clk@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bill Huang <bilhuang@...dia.com>
Subject: Re: [PATCH v4 09/20] clk: tegra: pll: Add logic for SS

On 5/4/2015 7:11 PM, Benson Leung wrote:
> On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein <rklein@...dia.com> wrote:
>> From: Bill Huang <bilhuang@...dia.com>
>>
>> Add some logic for Spread Spectrum control. It is used in conjuncture
>> with SDM fractional dividers. SSC has to be disabled when we configure
>> the divider settings.
>>
>> Signed-off-by: Bill Huang <bilhuang@...dia.com>
>> ---
>>  drivers/clk/tegra/clk-pll.c |   25 ++++++++++++++++++++++++-
>>  drivers/clk/tegra/clk.h     |    2 ++
>>  2 files changed, 26 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
>> index c64b75185d6b..2a559408cee1 100644
>> --- a/drivers/clk/tegra/clk-pll.c
>> +++ b/drivers/clk/tegra/clk-pll.c
>> @@ -621,6 +621,26 @@ static void _update_pll_cpcon(struct tegra_clk_pll *pll,
>>         pll_writel_misc(val, pll);
>>  }
>>
>> +static void pll_clk_start_ss(struct tegra_clk_pll *pll)
>> +{
>> +       if (pll->params->defaults_set && pll->params->ssc_ctrl_en_mask) {
> 
> defaults_set looks like it's introduced later (patch 16/20). Can you
> remove references to that, or reorder the patches if that makes more
> sense?
> 

I'll reorder this after set_defaults is added.

-rhyland

-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/