linux-kernel - Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 6 May 2015 08:12:09 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	xfs@....sgi.com, bfoster@...hat.com, sandeen@...deen.net,
	hch@....de, jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
> This makes the function,xfs_alloc_lookup_eq static as there are no
> calls to this function outside the definition file for this function,
> xfs_alloc.c.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  fs/xfs/libxfs/xfs_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index 516162b..48de3f0 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
>  /*
>   * Lookup the record equal to [bno, len] in the btree given by cur.
>   */
> -STATIC int				/* error */
> +static int				/* error */
>  xfs_alloc_lookup_eq(
>  	struct xfs_btree_cur	*cur,	/* btree cursor */
>  	xfs_agblock_t		bno,	/* starting block of extent */

Please have a look at what STATIC actually means, and then use the
sparse checker to confirm that these functions are already static
for a CONFIG_XFS_DEBUG=n build.

i.e. STATIC is a stack usage minimisation and debugging aid, not
something that is broken and needs fixing.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/