linux-kernel - Re: [PATCH 3.10 00/65] 3.10.77-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 May 2015 21:42:41 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
CC:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	shuah.kh@...sung.com, stable <stable@...r.kernel.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Rabin Vincent <rabin@....in>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3.10 00/65] 3.10.77-stable review

On 05/03/2015 09:40 PM, Guenter Roeck wrote:
> On 05/03/2015 12:49 PM, Guenter Roeck wrote:
>> On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 3.10.77 release.
>>> There are 65 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Mon May  4 19:00:04 UTC 2015.
>>> Anything received after that time might be too late.
>>>
>>
>> Build results:
>>      total: 127 pass: 113 fail: 14
>> Failed builds:
>>      arm:allmodconfig
>>      arm:multi_v7_defconfig
>>      arm:bcm2835_defconfig
>>      arm:orion5x_defconfig
>>      arm:kirkwood_defconfig
>>      arm:mvebu_defconfig
>>      mips:allmodconfig
>>      powerpc:allmodconfig
>>      powerpc:ppc6xx_defconfig
>>      s390:defconfig
>>      s390:allmodconfig
>>      sparc64:allmodconfig
>>      x86_64:allyesconfig
>>      x86_64:allmodconfig
>>
>> Qemu test results:
>>      total: 27 pass: 17 fail: 10
>> Failed tests:
>>      arm:arm_versatile_defconfig
>>      microblaze:microblaze_defconfig
>>      powerpc:ppc_book3s_defconfig
>>      powerpc:ppc_book3s_smp_defconfig
>>      powerpc:ppc64_book3s_defconfig
>>      powerpc:ppc64_book3s_smp_defconfig
>>      x86:x86_pc_defconfig
>>      x86:x86_pc_nosmp_defconfig
>>      x86_64:x86_64_pc_defconfig
>>      x86_64:x86_64_pc_nosmp_defconfig
>>
>> Builds fail with:
>>
>> kernel/trace/trace_functions_graph.c: In function 'graph_trace_open':
>> kernel/trace/trace_functions_graph.c:1397:2: error: implicit declaration of function 'alloc_percpu_gfp' [-Werror=implicit-function-declaration]
>> kernel/trace/trace_functions_graph.c:1397:36: error: expected expression before 'struct'
>>
>> Bisect points to 'tracing: Handle ftrace_dump() atomic context in graph_trace_open()'.
>>
>
> Also, for s390, similar to the error seen in 3.14:
>
> arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
> arch/s390/kernel/suspend.c:141:30: error: '_eshared' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:141:30: note: each undeclared identifier is reported only once for each function it appears in
> arch/s390/kernel/suspend.c:142:28: error: '_stext' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:10: error: 'ipl_info' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function)
>
> Presumably for the same reason ('s390/hibernate: fix save and restore of kernel text section').
>
> Guenter
>
Much better, but s390 images still fail to build:

arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
arch/s390/kernel/suspend.c:147:10: error: 'ipl_info' undeclared (first use in this function)
arch/s390/kernel/suspend.c:147:10: note: each undeclared identifier is reported only once for each function it appears in
arch/s390/kernel/suspend.c:147:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function)
make[2]: *** [arch/s390/kernel/suspend.o] Error 1

The problem can be fixed by adding "#include <asm/ipl.h>" to
arch/s390/kernel/suspend.c in "s390/hibernate: fix save and restore
of kernel text section" or possibly in "nosave: consolidate
__nosave_{begin,end} in <asm/sections.h>". Or, of course,
in a separate patch, such as the one attached.

Guenter



View attachment "0001-s390-Fix-build-error.patch" of type "text/x-diff" (956 bytes)