linux-kernel - Re: [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1430814879.3843.16.camel@x220>
Date:	Tue, 05 May 2015 10:34:39 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, dvhart@...radead.org, andy.schevchenko@...il.com,
	boon.leong.ong@...el.com, linux-kernel@...r.kernel.org,
	platform-driver-x86@...r.kernel.org, derek.browne@...el.com,
	josef.ahmad@...el.com, erik.nyquist@...el.com
Subject: Re: [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test

On Mon, 2015-05-04 at 03:17 +0100, Bryan O'Donoghue wrote:
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
 
> +config DEBUG_ESRAM_SELFTEST
> +	bool "Embedded SRAM self test"
> +	default n
> +	depends on INTEL_ESRAM
> +	---help---
> +	  This option enables automated sanity testing of the eSRAM driver
> +	  on Quark X1000. A simple set of tests with performance metrics
> +	  measured a DRAM baseline are run. These tests show the measured
> +	  performance increase across a given memory size for a series of
> +	  incrementing read sizes.
> +
> +	  If unsure say N here.

> --- a/arch/x86/platform/intel-quark/Makefile
> +++ b/arch/x86/platform/intel-quark/Makefile

> +obj-$(CONFIG_DEBUG_ESRAM_SELFTEST) += esram_selftest.o

DEBUG_ESRAM_SELFTEST is a bool Kconfig symbol. So esram_selftest.o will
never be part of a module, right?

> --- /dev/null
> +++ b/arch/x86/platform/intel-quark/esram_selftest.c

> + * IMR self test. The purpose of this module is to run a set of tests on the
> + * IMR API to validate it's sanity. We check for overlapping, reserved
> + * addresses and setup/teardown sanity.

> +MODULE_DEVICE_TABLE(x86cpu, esram_ids);

> +module_init(esram_self_test_init);
> +module_exit(esram_self_test_exit);
> +
> +MODULE_AUTHOR("Bryan O'Donoghue <pure.logic@...us-software.ie>");
> +MODULE_DESCRIPTION("Intel Quark eSRAM self-test driver");
> +MODULE_LICENSE("Dual BSD/GPL");

There's some module specific boilerplate above. (Note that I'm not sure
whether KBUILD_MODNAME is module specific, sorry.) And the comment talks
about a module too.

Was your intention to make DEBUG_ESRAM_SELFTEST a tristate symbol?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/