linux-kernel - [tip:timers/core] clocksource: integrator: Fix of_io_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-bd580e7ed4add8ce9b2c1dd1911f8fb9d444128b@git.kernel.org>
Date:	Tue, 5 May 2015 01:40:10 -0700
From:	tip-bot for Maxime Ripard <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	maxime.ripard@...e-electrons.com, daniel.lezcano@...aro.org,
	tglx@...utronix.de
Subject: [tip:timers/core] clocksource: integrator:
  Fix of_io_request_and_map error check

Commit-ID:  bd580e7ed4add8ce9b2c1dd1911f8fb9d444128b
Gitweb:     http://git.kernel.org/tip/bd580e7ed4add8ce9b2c1dd1911f8fb9d444128b
Author:     Maxime Ripard <maxime.ripard@...e-electrons.com>
AuthorDate: Sat, 2 May 2015 17:03:24 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 5 May 2015 10:35:58 +0200

clocksource: integrator: Fix of_io_request_and_map error check

of_io_request_and map returns an error pointer, but the current code assumes
that on error the returned pointer will be NULL.

Obviously, that makes the check completely useless. Change the test to actually
check for the proper error code.

Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
Link: http://lkml.kernel.org/r/1430579006-32702-5-git-send-email-maxime.ripard@free-electrons.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/clocksource/timer-integrator-ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-integrator-ap.c b/drivers/clocksource/timer-integrator-ap.c
index b9efd30..c97d198 100644
--- a/drivers/clocksource/timer-integrator-ap.c
+++ b/drivers/clocksource/timer-integrator-ap.c
@@ -166,7 +166,7 @@ static void __init integrator_ap_timer_init_of(struct device_node *node)
 	struct device_node *sec_node;
 
 	base = of_io_request_and_map(node, 0, "integrator-timer");
-	if (!base)
+	if (IS_ERR(base))
 		return;
 
 	clk = of_clk_get(node, 0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/