linux-kernel - Re: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 11:51:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jose Rivera <German.Rivera@...escale.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"agraf@...e.de" <agraf@...e.de>, "arnd@...db.de" <arnd@...db.de>,
	"bhupesh.sharma@...escale.com" <bhupesh.sharma@...escale.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stuart Yoder <stuart.yoder@...escale.com>,
	Scott Wood <scottwood@...escale.com>,
	"nir.erez@...escale.com" <nir.erez@...escale.com>,
	"itai.katz@...escale.com" <itai.katz@...escale.com>,
	"bhamciu1@...escale.com" <bhamciu1@...escale.com>,
	"R89243@...escale.com" <R89243@...escale.com>,
	Richard Schmitt <richard.schmitt@...escale.com>
Subject: Re: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC
 fw 7.0.0

On Mon, May 04, 2015 at 11:58:13PM +0000, Jose Rivera wrote:
> > 
> > On Tue, Apr 28, 2015 at 12:39:07PM -0500, J. German Rivera wrote:
> > > - Migrated MC bus driver to use DPRC flib 0.6.
> > 
> > What does this mean?  What is a flib?
> > 
> The DPRC flib is the API to manipulate DPRC objects. 
> 
> > After reading the patch, apparently it means that we can remove all the
> > ifdefs from patch 1.  :)
> > 
> No, we cannot as the required GIC-ITS support is not upstream yet.
> I added some of the #ifdefs back that were removed by mistake.
> 
> > > - Changed IRQ setup infrastructure to be able to program MSIs
> > >   for MC objects in an object-independent way.
> > 
> > Are these two things related?
> > 
> No.

When I asked this function I was partly wondering why they were broken
up the way they are.  This changelog was not enough information to start
reviewing the patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/