linux-kernel - Re: [PATCH v2 2/4] mm/page_alloc.c: add config option to sanitize freed pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 14:42:11 +0200
From:	Anisse Astier <anisse@...ier.eu>
To:	PaX Team <pageexec@...email.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	David Rientjes <rientjes@...gle.com>,
	Alan Cox <gnomes@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Brad Spengler <spender@...ecurity.net>,
	Kees Cook <keescook@...omium.org>,
	Andi Kleen <andi@...stfloor.org>, linux-mm@...ck.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] mm/page_alloc.c: add config option to sanitize
 freed pages

On Mon, May 4, 2015 at 11:50 PM, PaX Team <pageexec@...email.hu> wrote:
> On 4 May 2015 at 23:16, Anisse Astier wrote:
>
>> @@ -960,9 +966,15 @@ static int prep_new_page(struct page *page, unsigned int order, gfp_t gfp_flags,
>>       kernel_map_pages(page, 1 << order, 1);
>>       kasan_alloc_pages(page, order);
>>
>> +#ifndef CONFIG_SANITIZE_FREED_PAGES
>> +     /* SANITIZE_FREED_PAGES relies implicitly on the fact that pages are
>> +      * cleared before use, so we don't need gfp zero in the default case
>> +      * because all pages go through the free_pages_prepare code path when
>> +      * switching from bootmem to the default allocator */
>>       if (gfp_flags & __GFP_ZERO)
>>               for (i = 0; i < (1 << order); i++)
>>                       clear_highpage(page + i);
>> +#endif
>
> this hunk should not be applied before the hibernation fix otherwise
> bisect will break.
>

It will be re-ordered in v3, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/