linux-kernel - Re: [PATCH v2] selftests/mount: output WARN messages when mount test skipped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <554A764C.7080908@osg.samsung.com>
Date:	Wed, 06 May 2015 14:15:08 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Zhang Zhen <zhenzhang.zhang@...wei.com>, linux-api@...r.kernel.org,
	"linux-kernel@...r.kernel.org >> Linux Kernel Mailing List" 
	<linux-kernel@...r.kernel.org>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2] selftests/mount: output WARN messages when mount test
 skipped

On 04/02/2015 07:39 PM, Zhang Zhen wrote:
> Without this patch, if /proc/self/uid_map is not exist,
> the mount test case will skipped and no any prompting.
> 
> After applied this patch, the case will prompt why it skipped.
> Just as follows:
> root@...nel-host:/opt/kernel> make -C tools/testing/selftests TARGETS=mount run_tests
> make: Entering directory `/opt/kernel/tools/testing/selftests'
> for TARGET in mount; do \
>                 make -C $TARGET; \
>         done;
> make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount'
> make[1]: Nothing to be done for `all'.
> make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount'
> for TARGET in mount; do \
>                 make -C $TARGET run_tests; \
>         done;
> make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount'
> if [ -f /proc/self/uid_map ] ; then ./unprivileged-remount-test ; else echo "WARN: No /proc/self/uid_map exist, test skipped." ; fi
> WARN: No /proc/self/uid_map exist, test skipped.
> make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount'
> make: Leaving directory `/opt/kernel/tools/testing/selftests'
> 
> Change v1 -> v2:
> - fix syntax error when run kselftest_install.sh
> 
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@...wei.com>
> ---

Thanks for fixing this. Applied it to linux-kselftest next
for 4.2 - I ended up making changes the commit log to fix
checkpatch warnings before applying the patch.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/