linux-kernel - [PATCH] iio: hid-sensors: Fix memory leak on failure path in hid_prox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1430948924-4756-1-git-send-email-khoroshilov@ispras.ru>
Date:	Thu,  7 May 2015 00:48:44 +0300
From:	Alexey Khoroshilov <khoroshilov@...ras.ru>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: [PATCH] iio: hid-sensors: Fix memory leak on failure path in hid_prox_probe()

If prox_parse_report() fails, memory allocated for channels is not
deallocated, since it is still in local variable channels
while kfree() is called with indio_dev->channels.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
---
 drivers/iio/light/hid-sensor-prox.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index 91ecc46ffeaa..d0d188108a11 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -281,8 +281,9 @@ static int hid_prox_probe(struct platform_device *pdev)
 	ret = prox_parse_report(pdev, hsdev, channels,
 				HID_USAGE_SENSOR_PROX, prox_state);
 	if (ret) {
+		kfree(channels);
 		dev_err(&pdev->dev, "failed to setup attributes\n");
-		goto error_free_dev_mem;
+		return ret;
 	}
 
 	indio_dev->channels = channels;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/