linux-kernel - Re: [PATCH perf/core 6/8] perf-probe: Add --no-inlines option to avoid searching inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554AA221.4040000@hitachi.com>
Date:	Thu, 07 May 2015 08:22:09 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	ananth@...ibm.com, Peter Zijlstra <peterz@...radead.org>,
	hemant@...ux.vnet.ibm.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>, namhyung@...nel.org,
	Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH perf/core 6/8] perf-probe: Add --no-inlines option to
 avoid searching inline functions

On 2015/05/07 0:52, Arnaldo Carvalho de Melo wrote:
> Em Wed, May 06, 2015 at 09:46:51PM +0900, Masami Hiramatsu escreveu:
>> Add --no-inlines(--inlines) option to avoid searching inline
>> functions.
>> Searching all functions which matches glob pattern can take a
>> long time and find a lot of inline functions. With this option
>> perf-probe searches target on the non-inlined functions.
>>
>>  
>>  		ret = add_perf_probe_events(params.events, params.nevents,
>>  					    params.max_probe_points,
>> -					    params.force_add);
>> +					    params.force_add,
>> +					    params.no_inlines);
> 
> So, there is just one call to this function, and all the parameters come
> from the 'param' struct, why not just pass it?

Hm, the reason why I don't do that is for readability in
util/probe-event.c side. Passing params to the callee involves
 - export params struct (not be static)
 - callee has to extract required parameters from params.
 - it makes obscure that what parameters will be used in the method.

However, it seems that some of them would be better global configs
like symbol_conf. I'd like to suggest to introduce probe_conf global
config. Is it OK ?

Thank you,

-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/