linux-kernel - Re: [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow selection of memory based on attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150506162929.f97cf487bd41686325f9da2f@linux-foundation.org>
Date:	Wed, 6 May 2015 16:29:29 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tony Luck <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow
 selection of memory based on attribute

On Wed, 29 Apr 2015 11:31:24 -0700 Tony Luck <tony.luck@...el.com> wrote:

> No functional changes
> 
> ...
>
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -61,7 +61,7 @@ extern bool movable_node_enabled;
>  
>  phys_addr_t memblock_find_in_range_node(phys_addr_t size, phys_addr_t align,
>  					    phys_addr_t start, phys_addr_t end,
> -					    int nid);
> +					    int nid, u32 flag);

Sometimes this is called "flag", other times it is called "flags".  Can
we please be consistent?  "flags" seems to be the way to go.

Also, memblock_region.flags has type unsigned long, but you've used
u32.  ulong seems better.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/