linux-kernel - Re: [V2 PATCH 3/5] device property: Introduces device_dma_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gbSFrjce0oZwxOiGYVwx+bp3hJ+YghgO75dyf3iuiWYA@mail.gmail.com>
Date:	Thu, 7 May 2015 01:58:53 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>, thomas.lendacky@....com,
	herbert@...dor.apana.org.au, David Miller <davem@...emloft.net>,
	msalter@...hat.com, Hanjun Guo <hanjun.guo@...aro.org>,
	Al Stone <al.stone@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Arnd Bergmann <arnd@...db.de>, leo.duran@....com,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
	netdev@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent()

On Thu, May 7, 2015 at 1:52 AM, Suravee Suthikulanit
<suravee.suthikulpanit@....com> wrote:
> Rafael,
>
> Any comments on this patch?

Well, as long as acpi_dma_is_coherent() does the right thing on all
architectures, I have no objections.

Thanks,
Rafael


> On 5/5/2015 10:12 AM, Suravee Suthikulpanit wrote:
>>
>> Currently, device drivers, which support both OF and ACPI,
>> need to call two separate APIs, of_dma_is_coherent() and
>> acpi_dma_is_coherent()) to determine device coherency attribute.
>>
>> This patch simplifies this process by introducing a new device
>> property API, device_dma_is_coherent(), which calls the appropriate
>> interface based on the booting architecture.
>>
>> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
>> ---
>>   drivers/base/property.c  | 12 ++++++++++++
>>   include/linux/property.h |  2 ++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index 1d0b116..8123c6e 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -14,6 +14,7 @@
>>   #include <linux/export.h>
>>   #include <linux/kernel.h>
>>   #include <linux/of.h>
>> +#include <linux/of_address.h>
>>   #include <linux/property.h>
>>
>>   /**
>> @@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct
>> device *dev)
>>         return count;
>>   }
>>   EXPORT_SYMBOL_GPL(device_get_child_node_count);
>> +
>> +bool device_dma_is_coherent(struct device *dev)
>> +{
>> +       if (IS_ENABLED(CONFIG_OF) && dev->of_node)
>> +               return of_dma_is_coherent(dev->of_node);
>> +       else if (has_acpi_companion(dev))
>> +               return acpi_dma_is_coherent(acpi_node(dev->fwnode));
>> +
>> +       return false;
>> +}
>> +EXPORT_SYMBOL_GPL(device_dma_is_coherent);
>> diff --git a/include/linux/property.h b/include/linux/property.h
>> index de8bdf4..76ebde9 100644
>> --- a/include/linux/property.h
>> +++ b/include/linux/property.h
>> @@ -164,4 +164,6 @@ struct property_set {
>>
>>   void device_add_property_set(struct device *dev, struct property_set
>> *pset);
>>
>> +bool device_dma_is_coherent(struct device *dev);
>> +
>>   #endif /* _LINUX_PROPERTY_H_ */
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/