linux-kernel - Re: [PATCH 201/208] x86/fpu: Clean up xstate feature reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506045443.GB12393@gmail.com>
Date:	Wed, 6 May 2015 06:54:43 +0200
From:	Ingo Molnar <mingo2.kernel.org@...il.com>
To:	Dave Hansen <dave.hansen@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	Borislav Petkov <bp@...en8.de>,
	Fenghua Yu <fenghua.yu@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 201/208] x86/fpu: Clean up xstate feature reservation


* Dave Hansen <dave.hansen@...ux.intel.com> wrote:

> On 05/05/2015 10:58 AM, Ingo Molnar wrote:
> >  struct xregs_state {
> >  	struct fxregs_state		i387;
> >  	struct xstate_header		header;
> > -	struct ymmh_struct		ymmh;
> > -	struct lwp_struct		lwp;
> > -	struct bndreg			bndreg[4];
> > -	struct bndcsr			bndcsr;
> > -	/* New processor state extensions will go here. */
> > +	u8				__reserved[XSTATE_RESERVE];
> >  } __attribute__ ((packed, aligned (64)));
> 
> Just to reiterate.  The size of 'XSTATE_RESERVE' is completely 
> unknown at compile time.  [...]

Yes, see my previous mail.

> [...] It's wrong in the existing kernel, but we should fix it up 
> instead of mucking with it like this.

I'm not mucking with it, I'm slowly migrating it towards a dynamic 
model that doesn't suck - see my other mails.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/