[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150506053147.GB820@swordfish>
Date: Wed, 6 May 2015 14:31:47 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
Minchan Kim <minchan@...nel.org>,
Nitin Gupta <ngupta@...are.org>, linux-kernel@...r.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCHv4 00/10] add on-demand device creation
On (05/04/15 21:38), Sergey Senozhatsky wrote:
> We currently don't support zram on-demand device creation. The only way
> to have N zram devices is to specify num_devices module parameter (default
> value 1). That means that if, for some reason, at some point, user wants
> to have N + 1 devies he/she must umount all the existing devices, unload
> the module, load the module passing num_devices equals to N + 1.
>
> This patchset introduces zram-control sysfs class, which has two sysfs
> attrs:
>
> - zram_add -- add a new zram device
> - zram_remove -- remove a specific (device_id) zram device
>
> Usage example:
> # add a new specific zram device
> cat /sys/class/zram-control/zram_add
> 1
>
> # remove a specific zram device
> echo 4 > /sys/class/zram-control/zram_remove
>
Andrew,
could you please drop the entire series from -mm? Minchan has reported a
problem (requires some investigation) and proposed several changes, f.e.
to rename zram confrol's sysfs nodes to zram_control/{hot_add, hot_remove}.
to drop:
zram-add-dynamic-device-add-remove-functionality.patch added to -mm tree
zram-close-race-by-open-overriding.patch added to -mm tree
zram-return-zram-device_id-from-zram_add.patch added to -mm tree
zram-trivial-correct-flag-operations-comment.patch added to -mm tree
zram-report-every-added-and-removed-device.patch added to -mm tree
zram-reorganize-code-layout.patch added to -mm tree
zram-remove-max_num_devices-limitation.patch added to -mm tree
zram-use-idr-instead-of-zram_devices-array.patch added to -mm tree
zram-add-compact-sysfs-entry-to-documentation.patch added to -mm tree
zram-cosmetic-zram_attr_ro-code-formatting-tweak.patch added to -mm tree
thank you.
-ss
> V4:
> -- add patch from Minchan to handle differently a deadlock suspected by lockdep
> -- use zram->claim in zram_remove()
>
> V3:
> -- rebase against 4.1
> -- review comments from Minchan were addressed
> -- no sysfs RO tricks anymore
>
> V2:
> -- quick rebase and cleanup in attempt to catch 4.1 merge window
>
>
> Minchan Kim (1):
> zram: close race by open overriding
>
> Sergey Senozhatsky (9):
> zram: add `compact` sysfs entry to documentation
> zram: cosmetic ZRAM_ATTR_RO code formatting tweak
> zram: use idr instead of `zram_devices' array
> zram: reorganize code layout
> zram: remove max_num_devices limitation
> zram: report every added and removed device
> zram: trivial: correct flag operations comment
> zram: return zram device_id from zram_add()
> zram: add dynamic device add/remove functionality
>
> Documentation/ABI/testing/sysfs-class-zram | 24 +
> Documentation/blockdev/zram.txt | 29 +-
> drivers/block/zram/zram_drv.c | 1002 ++++++++++++++++------------
> drivers/block/zram/zram_drv.h | 10 +-
> 4 files changed, 612 insertions(+), 453 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-class-zram
>
> --
> 2.4.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists