linux-kernel - Re: [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55496761.7040509@rock-chips.com>
Date:	Wed, 06 May 2015 08:59:13 +0800
From:	Chris Zhong <zyw@...k-chips.com>
To:	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>
CC:	Dmitry Torokhov <dtor@...omium.org>,
	Sonny Rao <sonnyrao@...omium.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese
 keys



On 05/06/2015 02:10 AM, Doug Anderson wrote:
> Chris,
>
> On Mon, May 4, 2015 at 7:07 PM, Chris Zhong <zyw@...k-chips.com> wrote:
>> Add support for 4 Japanese keys
>>
>> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
>>
>> ---
>>
>>   arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> index 9c7fb0a..4e42f30c 100644
>> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> @@ -22,6 +22,7 @@
>>                          MATRIX_KEY(0x00, 0x02, KEY_F1)
>>                          MATRIX_KEY(0x00, 0x03, KEY_B)
>>                          MATRIX_KEY(0x00, 0x04, KEY_F10)
>> +                       MATRIX_KEY(0x00, 0x05, KEY_RO)
>>                          MATRIX_KEY(0x00, 0x06, KEY_N)
>>                          MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
>>                          MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
>> @@ -34,6 +35,7 @@
>>                          MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
>>                          MATRIX_KEY(0x01, 0x09, KEY_F9)
>>                          MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
>> +                       MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
>>
>>                          MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
>>                          MATRIX_KEY(0x02, 0x01, KEY_TAB)
>> @@ -45,6 +47,7 @@
>>                          MATRIX_KEY(0x02, 0x07, KEY_102ND)
>>                          MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>>                          MATRIX_KEY(0x02, 0x09, KEY_F8)
>> +                       MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>>
>>                          MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>>                          MATRIX_KEY(0x03, 0x02, KEY_F2)
>> @@ -53,6 +56,7 @@
>>                          MATRIX_KEY(0x03, 0x06, KEY_6)
>>                          MATRIX_KEY(0x03, 0x08, KEY_MINUS)
>>                          MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
>> +                       MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>>
>>                          MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
>>                          MATRIX_KEY(0x04, 0x01, KEY_A)
> Since there's no clear architecture here, I'd bet Olof would be the
> one to take this.  I added him to this email, but he might request
> that you resend the patch with him in the "To:" line.
>
> Other than that:
>
> Reviewed-by: Doug Anderson <dianders@...omium.org>
>
Thank you, I'll resend the patch with Olof.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/