[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAF1ivSZKSEfvXg_EUWkxkigLPVZNxQ0uEY7kns8CfE=nfLrCoQ@mail.gmail.com>
Date: Wed, 6 May 2015 00:13:14 -0700
From: Ming Lin <mlin@...nel.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: Ming Lin <mlin@...nel.org>, Christoph Hellwig <hch@....de>,
lkml <linux-kernel@...r.kernel.org>,
Jens Axboe <axboe@...nel.dk>,
Kent Overstreet <kent.overstreet@...il.com>,
Dongsu Park <dongsu.park@...fitbricks.com>,
Al Viro <viro@...iv.linux.org.uk>,
Ming Lei <ming.lei@...onical.com>, Neil Brown <neilb@...e.de>,
Alasdair Kergon <agk@...hat.com>,
Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com,
Lars Ellenberg <drbd-dev@...ts.linbit.com>,
drbd-user@...ts.linbit.com, Jiri Kosina <jkosina@...e.cz>,
Geoff Levand <geoff@...radead.org>, Jim Paris <jim@...n.com>,
Joshua Morris <josh.h.morris@...ibm.com>,
Philip Kelleher <pjk1939@...ux.vnet.ibm.com>,
Minchan Kim <minchan@...nel.org>,
Nitin Gupta <ngupta@...are.org>,
Oleg Drokin <oleg.drokin@...el.com>,
Andreas Dilger <andreas.dilger@...el.com>,
Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH 01/10] block: make generic_make_request handle arbitrarily
sized bios
On Tue, May 5, 2015 at 11:48 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, May 05, 2015 at 11:08:20PM -0700, Ming Lin wrote:
>> How about below incremental patch?
>
>> -
>> - /*
>> - * If the queue doesn't support SG gaps and adding this
>> - * offset would create a gap, disallow it.
>> - */
>> - if (q->queue_flags & (1 << QUEUE_FLAG_SG_GAPS) &&
>> - bvec_gap_to_prev(prev, offset))
>> - return 0;
>
> You need to keep the explicit checks for the BLOCK_PC case, as we can't
> split those.
I'll keep it. Thanks.
>
> Otherwise it looks fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists