linux-kernel - Re: [PATCH 09/27] leds: Allow compile test of GPIO consumers if !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 May 2015 10:31:46 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: Re: [PATCH 09/27] leds: Allow compile test of GPIO consumers if !GPIOLIB

Hi Jacek,

On Wed, May 6, 2015 at 9:58 AM, Jacek Anaszewski
<j.anaszewski@...sung.com> wrote:
> Why don't you apply the same modification to all LED Kconfig
> entries with GPIOLIB dependency?

LEDS_PCA9532_GPIO is a GPIO provider, not a consumer. There are no
dummies for GPIO providers.
LEDS_GPIO doesn't compile if !GPIOLIB, but I missed that it's just due to
a missing dummy for devm_get_gpiod_from_child() and a missing include.
Will fix.

Thanks!

> On 05/05/2015 06:32 PM, Geert Uytterhoeven wrote:
>> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
>> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
>> functionality only, can still be compiled if GPIOLIB is not enabled.
>>
>> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
>> appropriate.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/