linux-kernel - Re: [PATCH] tracing: Adds handler name to irq_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150505214619.14a60669@grimm.local.home>
Date:	Tue, 5 May 2015 21:46:19 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Badhri Jagan Sridharan <badhri@...gle.com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Adds handler name to irq_handler_entry

On Tue,  5 May 2015 17:46:58 -0700
Badhri Jagan Sridharan <badhri@...gle.com> wrote:

> This patch includes the ISR function name to
> irq_handler_entry trace point.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@...gle.com>
> ---
>  include/trace/events/irq.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
> index ff8f6c0..9994ba4 100644
> --- a/include/trace/events/irq.h
> +++ b/include/trace/events/irq.h
> @@ -58,14 +58,17 @@ TRACE_EVENT(irq_handler_entry,
>  	TP_STRUCT__entry(
>  		__field(	int,	irq		)
>  		__string(	name,	action->name	)
> +		__field(void*,	handler)

Please follow the format that the other fields have. This isn't a
function call to use the "checkpatch" version of indentation.

		__field(	void *,	handler		)

-- Steve

>  	),
>  
>  	TP_fast_assign(
>  		__entry->irq = irq;
>  		__assign_str(name, action->name);
> +		__entry->handler = action->handler;
>  	),
>  
> -	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
> +	TP_printk("irq=%d name=%s handler=%pf",
> +		__entry->irq, __get_str(name), __entry->handler)
>  );
>  
>  /**

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/