linux-kernel - Re: [PATCH 14/19] clk: versatile: Silence sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1430908303.3314.11.camel@arm.com>
Date:	Wed, 06 May 2015 11:31:43 +0100
From:	Pawel Moll <pawel.moll@....com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Mike Turquette <mturquette@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH 14/19] clk: versatile: Silence sparse warnings

On Wed, 2015-05-06 at 08:39 +0100, Stephen Boyd wrote:
> drivers/clk/versatile/clk-sp810.c:159:29: error: incompatible types for operation (<=)
> drivers/clk/versatile/clk-sp810.c:159:29:    left side has type char const *<noident>
> drivers/clk/versatile/clk-sp810.c:159:29:    right side has type int
> drivers/clk/versatile/clk-sp810.c:159:53: error: incompatible types for operation (<=)
> drivers/clk/versatile/clk-sp810.c:159:53:    left side has type char const *<noident>
> drivers/clk/versatile/clk-sp810.c:159:53:    right side has type int
> rivers/clk/versatile/clk-sp810.c:138:13: warning: symbol 'clk_sp810_of_setup' was not declared. Should it be static?
> 
> Cc: Pawel Moll <pawel.moll@....com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Acked-by: Pawel Moll <pawel.moll@....com>

> @@ -156,7 +156,7 @@ void __init clk_sp810_of_setup(struct device_node *node)
>  			"timclk");
>  	parent_names[1] = of_clk_get_parent_name(node, sp810->timclk_index);
>  
> -	if (parent_names[0] <= 0 || parent_names[1] <= 0) {
> +	if (!parent_names[0] || !parent_names[1]) {
>  		pr_warn("Failed to obtain parent clocks for SP810!\n");
>  		return;
>  	}

I stared at it (and at git blame output) and was thinking what was I
smoking typing the code... Fortunately mail history suggest that I had
"!parent..." in my original patch, and it was modified by Mike ;-) No
harm done :-)

Thanks for fixing this!

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/