lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150506110956.GN2067@n2100.arm.linux.org.uk>
Date:	Wed, 6 May 2015 12:09:56 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
	Mike Turquette <mturquette@...aro.org>,
	Lee Jones <lee@...nel.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Subject: Re: [PATCH v4 1/1] clkdev: change prototype of clk_register_clkdev()

On Wed, May 06, 2015 at 01:24:12PM +0300, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.

clk_register_clkdev() is there to assist mass clock registrations, which
typically happen in platform code.  It's there to simplify the "I need
to register this clock which I'm not going to release again".

I don't see any of these locations trying to unregister their clk from
clkdev, so I doubt this patch is needed.

Where a module wants to remove its clk from clkdev, it should register
its clk with clkdev_create() and remove it with clkdev_drop().

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ