linux-kernel - Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 May 2015 13:31:19 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Alex Hung <alex.hung@...onical.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Darren Hart <dvhart@...radead.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Gabriele Mazzotta <gabriele.mzt@...il.com>
Subject: Re: [PATCH v2 0/3] Dell Airplane Mode Switch driver

Looks like everything is OK. Test3 is expected to not work correctly as
driver is not loaded...

On Wednesday 06 May 2015 17:11:08 Alex Hung wrote:
> The test was updated @
> https://docs.google.com/spreadsheets/d/1voffS6dNglwAExSGh3UmG__UAO2qfZ829CkJLPo06aI/edit?usp=sharing.
> Please check the tab "Dell-rbtnv2"
> 
> Notes:
> 1. The systems come and go and I can find some of original ones but I
> tests some others
> 2. Test 3 was done by Test 2 + "rmmod dell-laptop". All were run with
> all wireless devices are ON
> 
> Summary:
> From external behaves such as Desktop's viewpoint (Unity was used and
> hope that's not surprising), the wireless devices are ON/OFF
> correctly. Other details are listed in the report.
> 
> On Sun, May 3, 2015 at 6:38 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> > On Wednesday 29 April 2015 11:51:03 Pali Rohár wrote:
> >> This patch series add new acpi Dell Airplane Mode Switch
> >> driver (DELLABCE and DELRBTN acpi devices). It provides radio
> >> HW switch events (together with current state of radio
> >> devices) and export them via rfkill interface. These events
> >> are also used in dell-laptop driver instead i8042 filter hook
> >> function (when acpi device is available).
> >>
> >> In v2 was added support for laptops which have toggle button
> >> instead HW slider switch. For that I reused code done by Alex
> >> Hung.
> >>
> >> Pali Rohár (3):
> >>   platform: x86: dell-rbtn: Dell Airplane Mode Switch driver
> >>   platform: x86: dell-rbtn: Export notifier for other kernel
> >> modules platform: x86: dell-laptop: Use dell-rbtn instead
> >> i8042 filter when possible
> >>
> >>  drivers/platform/x86/Kconfig       |   14 ++
> >>  drivers/platform/x86/Makefile      |    1 +
> >>  drivers/platform/x86/dell-laptop.c |   67 +++++-
> >>  drivers/platform/x86/dell-rbtn.c   |  430
> >> ++++++++++++++++++++++++++++++++++++
> >> drivers/platform/x86/dell-rbtn.h   |   35 +++
> >>  5 files changed, 542 insertions(+), 5 deletions(-)
> >>  create mode 100644 drivers/platform/x86/dell-rbtn.c
> >>  create mode 100644 drivers/platform/x86/dell-rbtn.h
> >
> > Alex, can you rested this patch series on all your machines like
> > you did previous in this sheet?
> >
> > https://docs.google.com/spreadsheets/d/1voffS6dNglwAExSGh3UmG__UAO2qfZ829CkJLPo06aI/edit?usp=sharing
> >
> > Ideally do more tests:
> > 1) only with first patch 1/3
> > 2) with full patch series 1/3, 2/3, 3/3 *with* loaded dell-laptop
> > 3) same as 2) but without loaded dell-laptop
> >
> > If everything pass then this patch series is OK from my side.
> >
> > Looks like Gabriele's problem is irrelevant to this patch series,
> > but we probably hit some rfkill bug in dell-laptop.ko :-(
> >
> > Matthew or Darren, can you review code in this patch series? So
> > if everything will be fine, dell-rbtn could be ready for 4.2.
> >
> > --
> > Pali Rohár
> > pali.rohar@...il.com
> 
> 
> 

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/