[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdZqftDFEaXTFYV=9hmoCmDH+FDmNHdMN9_Se9dgiuc7xQ@mail.gmail.com>
Date: Wed, 6 May 2015 15:09:45 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Semen Protsenko <semen.protsenko@...ballogic.com>
Cc: Alexandre Courbot <gnurou@...il.com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Grygorii Strashko <grygorii.strashko@...ballogic.com>
Subject: Re: [PATCH v2] gpio: max732x: Fix irq-events handler
On Wed, Apr 22, 2015 at 3:20 PM, Semen Protsenko
<semen.protsenko@...ballogic.com> wrote:
> MAX732X clears all pending interrupts on I2C read (when interrupts
> register is being read). Driver doesn't need to send any ACKs when
> interrupt was handled. So replace handle_edge_irq() with
> handle_simple_irq().
>
> Using handle_edge_irq() (w/o .irq_ack callback set) may lead to NULL
> pointer dereference in some cases. E.g. this was observed on
> hibernation process:
>
> Unable to handle kernel NULL pointer dereference at virtual address 0
> Backtrace:
> (handle_edge_irq) from (resend_irqs)
> (resend_irqs) from (tasklet_action)
> (tasklet_action) from (__do_softirq)
> (__do_softirq) from (run_ksoftirqd)
> (run_ksoftirqd) from (smpboot_thread_fn)
> (smpboot_thread_fn) from (kthread)
> (kthread) from (ret_from_fork)
>
> Signed-off-by: Semen Protsenko <semen.protsenko@...ballogic.com>
Patch applied with Grygorii's Review tag.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists