linux-kernel - Re: [PATCH 04/19] clk: bcm/kona: Silence sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554A1576.8070007@linaro.org>
Date:	Wed, 06 May 2015 08:21:58 -0500
From:	Alex Elder <elder@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>,
	Mike Turquette <mturquette@...aro.org>
CC:	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	Tim Kryger <tim.kryger@...aro.org>
Subject: Re: [PATCH 04/19] clk: bcm/kona: Silence sparse warnings

On 05/06/2015 02:39 AM, Stephen Boyd wrote:
> drivers/clk/bcm/clk-kona.c:1243:16: warning: odd constant _Bool cast (ffffffffffffffea becomes 1)
> 
> Cc: Alex Elder <elder@...aro.org>
> Cc: Tim Kryger <tim.kryger@...aro.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Looks good.
Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>  drivers/clk/bcm/clk-kona.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c
> index a0ef4f75d457..79a98506c433 100644
> --- a/drivers/clk/bcm/clk-kona.c
> +++ b/drivers/clk/bcm/clk-kona.c
> @@ -1240,7 +1240,7 @@ static bool __kona_clk_init(struct kona_clk *bcm_clk)
>  	default:
>  		BUG();
>  	}
> -	return -EINVAL;
> +	return false;
>  }
>  
>  /* Set a CCU and all its clocks into their desired initial state */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/