linux-kernel - Re: [PATCH] staging: lustre: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150506135235.GC14154@mwanda>
Date:	Wed, 6 May 2015 16:52:35 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mike Shuey <shuey@...due.edu>
Cc:	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, HPDD-discuss@...1.01.org
Subject: Re: [PATCH] staging: lustre: code cleanup - variable declaration
 spacing

On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote:
> Clean up spacing in some variable declarations, to be more consistent.
> 
> It's small, but I need to start somewhere.  Please let me know if I'm not
> adhering to proper procedure for trivial cleanups.

Don't put these "aside" comments in the permanent kernel changelog.

Otherwise I like this patch, lining up the variables can look ok in
struct definitions in headers but in functions we can never keep it
consistent so it just looks whacky.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/