linux-kernel - Re: [PATCH V2 1/6] x86/MCE/AMD: Factor out logging mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554A53B7.5030201@amd.com>
Date:	Wed, 6 May 2015 12:47:35 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<tony.luck@...el.com>, <jiang.liu@...ux.intel.com>,
	<yinghai@...nel.org>, <x86@...nel.org>, <dvlasenk@...hat.com>,
	<JBeulich@...e.com>, <slaoub@...il.com>, <luto@...capital.net>,
	<dave.hansen@...ux.intel.com>, <oleg@...hat.com>,
	<rostedt@...dmis.org>, <rusty@...tcorp.com.au>,
	<prarit@...hat.com>, <linux@...musvillemoes.dk>, <jroedel@...e.de>,
	<andriy.shevchenko@...ux.intel.com>, <macro@...ux-mips.org>,
	<wangnan0@...wei.com>, <linux-kernel@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <rric@...nel.org>
Subject: Re: [PATCH V2 1/6] x86/MCE/AMD: Factor out logging mechanism

On 5/6/2015 12:41 PM, Borislav Petkov wrote:
>
> Yeah, let's save us the mce_setup() work in the !MCI_STATUS_VAL case:
>

Sure, thanks for fixing it.

> +static void __log_error(unsigned int bank, bool threshold_err, u64 misc)
> +{
> +	struct mce m;
> +	u64 status;
> +
> +	rdmsrl(MSR_IA32_MCx_STATUS(bank), status);
> +	if (!(status & MCI_STATUS_VAL))
> +		return;
> +
> +	mce_setup(&m);
> +
>


-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/