[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20150507143034.250f8632c8179ba1950d6798@linux-foundation.org>
Date: Thu, 7 May 2015 14:30:34 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Tony Luck <tony.luck@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 2/3] mm/memblock: Allocate boot time data structures
from mirrored memory
On Thu, 7 May 2015 14:24:46 -0700 Tony Luck <tony.luck@...il.com> wrote:
> On Wed, May 6, 2015 at 4:30 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> >> + if (!ret && flag) {
> >> + pr_warn("Could not allocate %lld bytes of mirrored memory\n", size);
> >
> > This printk will warn on some configs. Print a phys_addr_t with %pap.
> > I think. See huge comment over lib/vsprintf.c:pointer().
>
> The comment may be huge - but it seems to lie about phys_addr_t :-(
>
> I changed to %pap and got:
>
> mm/memblock.c: In function 'memblock_find_in_range':
> mm/memblock.c:276:3: warning: format '%p' expects argument of type
> 'void *', but argument 2 has type 'phys_addr_t' [-Wformat=]
> pr_warn("Could not allocate %pap bytes of mirrored memory\n",
Use "&size" rather than "size". All the %p extensions require a
pointer to the thing-to-be-printed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists