linux-kernel - Re: [PATCH v2] iio: mcp320x: Fix occasional incorrect readings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554B3ABB.7050306@kernel.org>
Date:	Thu, 07 May 2015 11:13:15 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Michael Welling <mwelling@...e.org>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, san@...etechnology.dk,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH v2] iio: mcp320x: Fix occasional incorrect readings

On 06/05/15 17:49, Michael Welling wrote:
> Without the cacheline alignment, the readings will occasionally incorrectly
> return 0.
> 
> Signed-off-by: Michael Welling <mwelling@...e.org>
Applied to the fixes-togreg branch of iio.git.  Not sure
when I'll be able to push this out publicly as travelling
/ working nights and generally having a silly week.

J
> ---
> 
> v2: Moved buffers to the end of the mcp320x struct per suggestion to keep
> them on their own cacheline.
> 
>  drivers/iio/adc/mcp320x.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index efbfd12..8d9c9b9 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -60,12 +60,12 @@ struct mcp320x {
>  	struct spi_message msg;
>  	struct spi_transfer transfer[2];
>  
> -	u8 tx_buf;
> -	u8 rx_buf[2];
> -
>  	struct regulator *reg;
>  	struct mutex lock;
>  	const struct mcp320x_chip_info *chip_info;
> +
> +	u8 tx_buf ____cacheline_aligned;
> +	u8 rx_buf[2];
>  };
>  
>  static int mcp320x_channel_to_tx_data(int device_index,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/