linux-kernel - Re: [PATCH] iio: kfifo: Set update_needed to false only if a buffer was allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <554BE954.6030001@kernel.org>
Date:	Thu, 07 May 2015 23:38:12 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Gabriele Mazzotta <gabriele.mzt@...il.com>
CC:	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: kfifo: Set update_needed to false only if a buffer
 was allocated

On 02/05/15 13:31, Gabriele Mazzotta wrote:
> Check whether the allocation of a new kfifo buffer failed or not before
> setting the update_needed flag to false. This will make
> iio_request_update_kfifo() try to allocate a new buffer the next time a
> buffer update is requested.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
Applied to the fixes to greg branch of iio.git

The way things are going right now, I might actually get time to
push this out on Saturday.... Which is more than I expected this
morning.

J
> ---
>  drivers/iio/kfifo_buf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/kfifo_buf.c b/drivers/iio/kfifo_buf.c
> index 847ca56..55c267b 100644
> --- a/drivers/iio/kfifo_buf.c
> +++ b/drivers/iio/kfifo_buf.c
> @@ -38,7 +38,8 @@ static int iio_request_update_kfifo(struct iio_buffer *r)
>  		kfifo_free(&buf->kf);
>  		ret = __iio_allocate_kfifo(buf, buf->buffer.bytes_per_datum,
>  				   buf->buffer.length);
> -		buf->update_needed = false;
> +		if (ret >= 0)
> +			buf->update_needed = false;
>  	} else {
>  		kfifo_reset_out(&buf->kf);
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/