linux-kernel - Re: [PATCH 23/27] backlight: Allow compile test of GPIO consumers if !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150507073708.GA12484@x1>
Date:	Thu, 7 May 2015 08:37:08 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Arnd Bergmann <arnd@...db.de>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 23/27] backlight: Allow compile test of GPIO consumers if
 !GPIOLIB

On Tue, 05 May 2015, Geert Uytterhoeven wrote:

> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
> 
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Jingoo Han <jg1.han@...sung.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: linux-fbdev@...r.kernel.org
> ---
>  drivers/video/backlight/Kconfig | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Looks good.  Applied, thanks.

> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 2d9923a60076e380..0505b796d743250e 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -36,14 +36,16 @@ config LCD_CORGI
>  
>  config LCD_L4F00242T03
>  	tristate "Epson L4F00242T03 LCD"
> -	depends on SPI_MASTER && GPIOLIB
> +	depends on SPI_MASTER
> +	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  SPI driver for Epson L4F00242T03. This provides basic support
>  	  for init and powering the LCD up/down through a sysfs interface.
>  
>  config LCD_LMS283GF05
>  	tristate "Samsung LMS283GF05 LCD"
> -	depends on SPI_MASTER && GPIOLIB
> +	depends on SPI_MASTER
> +	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  SPI driver for Samsung LMS283GF05. This provides basic support
>  	  for powering the LCD up/down through a sysfs interface.
> @@ -434,7 +436,7 @@ config BACKLIGHT_AS3711
>  
>  config BACKLIGHT_GPIO
>  	tristate "Generic GPIO based Backlight Driver"
> -	depends on GPIOLIB
> +	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  If you have a LCD backlight adjustable by GPIO, say Y to enable
>  	  this driver.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/