linux-kernel - Re: [PATCH] staging: fbtft: force cast to non-_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150507083908.GF14154@mwanda>
Date:	Thu, 7 May 2015 11:39:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Garret Kelly <gdk@...gle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	Noralf Trønnes <noralf@...nnes.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer

On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote:
> > Can't we fix this properly, to use the correct type of pointer instead
> > for non-__iomem allocations?
> 
> You mean making an alternate screen_base pointer inside fb_info that
> isn't __iomem?  There are already a bunch of framebuffer drivers that
> (ab)use screen_base to store non-__iomem pointers, so this didn't
> strike me as too far out of line.

You could add a new pointer or you could just make ->screen_base a
union.  I'm not sure which is the best.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/