linux-kernel - Re: [PATCH] KVM: remove pointless cpu hotplug messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <554B30F1.506@redhat.com>
Date:	Thu, 07 May 2015 11:31:29 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: remove pointless cpu hotplug messages



On 05/05/2015 09:39, Heiko Carstens wrote:
> On cpu hotplug only KVM emits an unconditional message that its notifier
> has been called. It certainly can be assumed that calling cpu hotplug
> notifiers work, therefore there is no added value if KVM prints a message.
> 
> If an error happens on cpu online KVM will still emit a warning.
> 
> So let's remove this superfluous message.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  virt/kvm/kvm_main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 90977418aeb6..5fb52af5b975 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2882,18 +2882,12 @@ static int hardware_enable_all(void)
>  static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
>  			   void *v)
>  {
> -	int cpu = (long)v;
> -
>  	val &= ~CPU_TASKS_FROZEN;
>  	switch (val) {
>  	case CPU_DYING:
> -		pr_info("kvm: disabling virtualization on CPU%d\n",
> -		       cpu);
>  		hardware_disable();
>  		break;
>  	case CPU_STARTING:
> -		pr_info("kvm: enabling virtualization on CPU%d\n",
> -		       cpu);
>  		hardware_enable();
>  		break;
>  	}
> 

Applied, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/