linux-kernel - Re: [PATCH v3 3/4] block: loop: use kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 May 2015 18:32:03 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dave Kleikamp <dave.kleikamp@...cle.com>,
	Jens Axboe <axboe@...nel.dk>, Zach Brown <zab@...bo.net>,
	Maxim Patlasov <mpatlasov@...allels.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v3 3/4] block: loop: use kthread_work

On Thu, May 7, 2015 at 3:17 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Thu, May 07, 2015 at 01:08:25AM +0800, Ming Lei wrote:
>> The following patch will use dio/aio to submit IO to backing file,
>> then it isn't good to schedule IO concurrently from work, so
>> use kthread_work.
>
> I can't really parse this, what's the specific advantage here?

Patch 4's commit log provides the test data.

>From the data, it is observed that one thread is enough to get
similar throughput with previous one which submits IO from
work concurrently.

Single thread can decrease context switch a lots, also one thread is
often used to submit AIO in reality.

Thanks,
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/