linux-kernel - Re: [PATCH v2 00/15] HID: hid-lg, hid-lg4ff: Mostly cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1505071628560.8186@pobox.suse.cz>
Date:	Thu, 7 May 2015 16:29:03 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Michal Malý <madcatxster@...oid-pointer.net>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	elias.vds@...il.com, simon@...gewell.org
Subject: Re: [PATCH v2 00/15] HID: hid-lg, hid-lg4ff: Mostly cleanup
 patches

On Wed, 8 Apr 2015, Michal Malý wrote:

> Hello everyone,
> 
> this is a mostly boring series that deals with a few inconsistencies in the
> code that have accumulated over the years. Besides that it patches up a handful
> of problems such a return values not being checked etc.
> 
> The only significant change comes in patches 8 through 10 which introduce a
> spinlock to handle concurrent access to the HID report that is used by the
> driver to send data to the wheel. I would appreciate some comments on this one,
> particularly on the way it handles deinitialization. Patches 8 and 9 contain
> the necessary prep work, patch 10 adds the spinlocking.
> 
> v2:
>   - Split previous patch 7 into three smaller patches
>   - Split the long line of text in patch 5 (now patch 6)
>   - Add another cleanup patch that removes unnecessary casts from void *

This is a nice cleanup. I've applied it to for-4.2/logitech.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/