linux-kernel - Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1505071031200.2272-100000@iolanthe.rowland.org>
Date:	Thu, 7 May 2015 10:34:20 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Lu, Baolu" <baolu.lu@...ux.intel.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...el.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] usb: notify hcd when USB device suspend or resume

On Thu, 7 May 2015, Lu, Baolu wrote:

> >> +	void	(*device_suspend)(struct usb_hcd *, struct usb_device *udev,
> >> +			pm_message_t msg);
> >> +	void	(*device_resume)(struct usb_hcd *, struct usb_device *udev,
> >> +			pm_message_t msg);
> >>   };
> > Your callbacks don't use the msg argument.  What makes you think it is
> > needed?
> 
> This msg argument is valuable. XHCI spec defines a capability named FSC
> (Force Save context Capability). When this capability is implemented, the
> Save State operation (do during host suspend) shall save any cached Slot,
> Endpoint, Stream or other Context information to memory. xHCI hcd could
> use this "msg" to determine whether it needs to issue stop endpoint with
> SP (suspend) bit set.

I don't understand.  What is the advantage of using FSC?

How would xhci-hcd use "msg" to determine this?  And why doesn't your
2/3 patch already do it?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/