linux-kernel - Re: [PATCH 02/10] drivers:host:fsl: Use ehci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1505071037180.2272-100000@iolanthe.rowland.org>
Date:	Thu, 7 May 2015 10:46:07 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
cc:	linux-kernel@...r.kernel.org, <balbi@...com>,
	<linux-usb@...r.kernel.org>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure
 for EHCI drv

On Thu, 7 May 2015, Ramneek Mehresh wrote:

> Make use of ehci_driver_overrides structure for ehci-fsl
> driver
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@...escale.com>

You need to change a lot more than this.  See commit a76dd463c58e (USB: 
EHCI: make ehci-orion a separate driver) as an example of what is 
needed.  In the end, ehci-fsl.ko should be a new driver module, not 
compiled into ehci-hcd.ko.

> +	ehci_init_driver(driver, &ehci_fsl_overrides);
> +	driver->product_desc = "Freescale On-Chip EHCI Host Controller";
> +	driver->start = ehci_run;
> +	driver->start_port_reset = ehci_start_port_reset;

Why do you want to override driver->start?  The default value 
for this field is already set to ehci_run.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/