linux-kernel - Re: [PATCH v2 01/10] arch: introduce __pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508005536.312c3eff@canb.auug.org.au>
Date:	Fri, 8 May 2015 00:55:36 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk, riel@...hat.com,
	linux-nvdimm@...ts.01.org, mingo@...nel.org,
	linux-fsdevel@...r.kernel.org, mgorman@...e.de,
	"H. Peter Anvin" <hpa@...or.com>, Tejun Heo <tj@...nel.org>,
	akpm@...ux-foundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>, hch@....de
Subject: Re: [PATCH v2 01/10] arch: introduce __pfn_t for persistent memory
 i/o

Hi Dan,

On Wed, 06 May 2015 16:04:59 -0400 Dan Williams <dan.j.williams@...el.com> wrote:
>
> diff --git a/include/asm-generic/pfn.h b/include/asm-generic/pfn.h
> new file mode 100644
> index 000000000000..91171e0285d9
> --- /dev/null
> +++ b/include/asm-generic/pfn.h
> @@ -0,0 +1,51 @@
> +#ifndef __ASM_PFN_H
> +#define __ASM_PFN_H
> +
> +#ifndef __pfn_to_phys
> +#define __pfn_to_phys(pfn)      ((dma_addr_t)(pfn) << PAGE_SHIFT)

Why dma_addr_t and not phys_addr_t?  i.e. it could use a comment if it
is correct.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped