linux-kernel - Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431011187.16884.0.camel@mtksdaap41>
Date:	Thu, 7 May 2015 23:06:27 +0800
From:	Eddie Huang <eddie.huang@...iatek.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Joe Perches <joe@...ches.com>, Lee Jones <lee.jones@...aro.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	<srv_heupstream@...iatek.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Greg KH" <gregkh@...uxfoundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Tejun Heo <tj@...nel.org>, <linux-kernel@...r.kernel.org>,
	<rtc-linux@...glegroups.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Tomasz Figa <tfiga@...gle.com>,
	Tianping Fang <tianping.fang@...iatek.com>
Subject: Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver

Hi Alexandre,

On Thu, 2015-05-07 at 14:06 +0200, Alexandre Belloni wrote:
> On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote :
> > On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> > > From: Tianping Fang <tianping.fang@...iatek.com>
> > 
> > trivia: no need to resend now, maybe in a future patch.
> > 
> > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> > []
> > > +static int mtk_rtc_probe(struct platform_device *pdev)
> > > +{
> > []
> > > +	ret = request_threaded_irq(rtc->irq, NULL,
> > > +				   mtk_rtc_irq_handler_thread,
> > > +				   IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> > > +			"mt6397-rtc", rtc);
> > 
> > It'd be nicer to align all the statement lines
> > to that open parenthesis
> > 
> > 
> 
> I'll fix it up when applying.
> 
Thanks your great help

Eddie



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/