linux-kernel - Re: problem building on ARM with XEN enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1505071736130.9885@kaball.uk.xensource.com>
Date:	Thu, 7 May 2015 17:37:57 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
CC:	Michal Suchanek <hramrach@...il.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	<xen-devel@...ts.xenproject.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: problem building on ARM with XEN enabled

On Thu, 7 May 2015, Boris Ostrovsky wrote:
> On 05/07/2015 11:10 AM, Michal Suchanek wrote:
> > Hello,
> > 
> > it appears the Linus master tree fails to build on ARM with XEN enabled.
> > 
> > Since commit 2b953a5e9 xen: Suspend ticks on all CPUs during suspend
> > 
> > provides the suspend function only for x86 this is not surprising.
> > 
> > I currently don't use XEN yet but building with XEN enabled was not a
> > problem in the past so this looks like a regression to me.
> 
> 
> 
> (+Stefano)
> 
> Does this fix it:

Yes, it does. Please go ahead and add it to xentip.


> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 224081c..7d0f070 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
>  void xen_arch_post_suspend(int suspend_cancelled) { }
>  void xen_timer_resume(void) { }
>  void xen_arch_resume(void) { }
> +void xen_arch_suspend(void) { }
> 
> 
>  /* In the hypervisor.S file. */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/