linux-kernel - Re: [PATCH] VFS: Add back check for !inode in walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150507134359.458e933c@gandalf.local.home>
Date:	Thu, 7 May 2015 13:43:59 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	David Howells <dhowells@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] VFS: Add back check for !inode in walk_component()

On Thu, 7 May 2015 13:39:35 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 7 May 2015 18:28:34 +0100
> Al Viro <viro@...IV.linux.org.uk> wrote:
> 
> > On Thu, May 07, 2015 at 12:52:41PM -0400, Steven Rostedt wrote:
> > > 
> > > Commit 698934df8b45 "VFS: Combine inode checks with d_is_negative() and
> > > d_is_positive() in pathwalk" removed a check for inode being NULL in
> > > walk_component() where the type is tested. Stressing my tracefs create
> > > and remove instances while reading the files now triggers this:
> > 
> > So you get NULL ->d_inode with stale flags?  The thing is, ->d_inode
> > becoming NULL should happen via d_delete(), which goes throug this:
> 
> But it's not the delete, it's the creation of a new d_entry. Pehaps it
> gets linked premature? The tracing I had happened in
> tracefs_create_file().
> 

Note, this could be because of my special hack to have mkdir create
files too. We never came up with a clean solution for that.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/