linux-kernel - Re: [PATCH 1/1] x86/vdso: add -Iarch/x86/include/uapi into HOST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrVoopCoxiT7pcCFZaDsh437yVc7r3V-tt5LXJ3Z6jWU+A@mail.gmail.com>
Date:	Thu, 7 May 2015 12:46:33 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...nel.org>,
	X86 ML <x86@...nel.org>
Cc:	Borislav Petkov <bp@...e.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jiri Olsa <jolsa@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86/vdso: add -Iarch/x86/include/uapi into HOST_EXTRACFLAGS

On Thu, May 7, 2015 at 9:58 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> Change HOST_EXTRACFLAGS to include arch/x86/include/uapi along with
> include/uapi.
>
> This looks more consistent, and this fixes "make bzImage" on my old
> distro which doesn't have asm/bitsperlong.h in /usr/include/.
>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Fixed: 6f121e548f83 x86, vdso: Reimplement vdso.so preparation in build-time C
Acked-by: Andy Lutomirski <luto@...nel.org>

Ingo, despite Oleg's rather late discovery of this, it's a regression
fix.  If you think it's appropriate for x86/urgent, please apply it.
Otherwise I'll queue it up.

--Andy

> ---
>  arch/x86/vdso/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
> index 275a3a8..e970320 100644
> --- a/arch/x86/vdso/Makefile
> +++ b/arch/x86/vdso/Makefile
> @@ -51,7 +51,7 @@ VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
>  $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE
>         $(call if_changed,vdso)
>
> -HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi
> +HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi -I$(srctree)/arch/x86/include/uapi
>  hostprogs-y                    += vdso2c
>
>  quiet_cmd_vdso2c = VDSO2C  $@
> --
> 1.5.5.1
>
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/