linux-kernel - Re: [PATCH 10/10] usb:fsl:otg: Make fsl otg driver as tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431074139.11180.7.camel@x220>
Date:	Fri, 08 May 2015 10:35:39 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
Cc:	linux-kernel@...r.kernel.org, balbi@...com,
	linux-usb@...r.kernel.org, stern@...land.harvard.edu,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 10/10] usb:fsl:otg: Make fsl otg driver as tristate

On Thu, 2015-05-07 at 18:17 +0530, Ramneek Mehresh wrote:
> Provide option to load fsl otg driver as loadable
> module

(Full stop at the end of that sentence, please.)

In case anyone is wondering: this is all that's needed to allow the
build of a phy-fsl-usb.ko module because the code already contains the
required module specific boilerplate. Actually, that boilerplate has
always been there since this driver was added in v3.0, as a built-in
only driver, through commit 0807c500a1a6 ("USB: add Freescale USB OTG
Transceiver driver").

(Of course, this assumes building modular and loading the module
actually works, none of which I have tried myself.)

> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@...escale.com>
> ---
>  drivers/usb/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 2175678..4927905 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -19,7 +19,7 @@ config AB8500_USB
>  	  in host mode, low speed.
>  
>  config FSL_USB2_OTG
> -	bool "Freescale USB OTG Transceiver Driver"
> +	tristate "Freescale USB OTG Transceiver Driver"
>  	depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM
>  	select USB_OTG
>  	select USB_PHY


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/