linux-kernel - Re: [̈́PATCHv4 01/12] usb: add bus type for USB ULPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508095621.GA6154@kuha.fi.intel.com>
Date:	Fri, 8 May 2015 12:56:21 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Felipe Balbi <balbi@...com>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>,
	Paul Bolle <pebolle@...cali.nl>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [̈́PATCHv4 01/12] usb: add bus type
 for USB ULPI

On Thu, May 07, 2015 at 10:46:04PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2015 at 09:19:21AM +0300, Heikki Krogerus wrote:
> > +config USB_ULPI_BUS
> > +	bool "USB ULPI PHY interface support"
> 
> Can't we make this a module?

There is actually nothing preventing it.

I removed the possibility of building this as a module at one point
because... I guess just because a voice inside my head told me to do
so. Thanks for catching this one.

> > +	depends on USB_SUPPORT
> > +	help
> > +	  Say yes if you have ULPI PHY attached to your USB controller.
> 
> You need to put more information here as to what "ULPI" means, and how
> would anyone know if they have this type of thing attached to their USB
> controller.
> 
> You need to help users / distros out in letting them know if they should
> enable this or not.  As it is, I have no idea if I should even enable
> this on my systems...

OK.


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/